Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Social Network Auth #535

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Fix Social Network Auth #535

merged 9 commits into from
Jan 10, 2024

Conversation

eluhr
Copy link
Contributor

@eluhr eluhr commented Jan 10, 2024

Q A
Is bugfix? yes
New feature? yes
Breaks BC? yes/no -> Update in interface but trait to support backward compatibility
Tests pass? yes
Fixed issues #359, #383

While I was trying to use the social account feature of the module, I noticed that the feature is not implemented properly in some places or does not work at all in some scenarios.

  • When attempting to log in for the first time via an unconnected network account, the user model is not saved in the database.
  • The SocialNetworkServices require an "id" field in the received data packet. More flexibility is provided by adapting the interface and providing a trait for backwards compatibility.
  • New property that allows login exclusively via social networks, regardless of the value of the "enableRegistration" property.
  • New property that allows you to prevent the sending of a "welcome message" when the user registers via a social network.

This PR solves these problems and at the same time provides a little more flexibility in use.

@maxxer
Copy link
Collaborator

maxxer commented Jan 10, 2024

Wow, thank you for the work! Please add an entry to the changelog then I'll merge it.

@eluhr
Copy link
Contributor Author

eluhr commented Jan 10, 2024

@maxxer thx! i just updated the changelog.

@maxxer maxxer merged commit 13a5420 into 2amigos:master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants